Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(binding-opcua): fix demo-opcua1.ts in README #1109

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Oct 9, 2023

Corresponding with #1013, this PR updates the example in the README file for the OPCUA binding, ticking two checkmarks. A more detailed description of how to run the example still needs to be added.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7cbe593) 75.54% compared to head (324dbc2) 75.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1109   +/-   ##
=======================================
  Coverage   75.54%   75.54%           
=======================================
  Files          80       80           
  Lines       16164    16164           
  Branches     1513     1513           
=======================================
  Hits        12211    12211           
  Misses       3914     3914           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @JKRhb

@relu91 relu91 merged commit 4ebe5e8 into eclipse-thingweb:master Oct 10, 2023
7 checks passed
@JKRhb JKRhb deleted the opcua-fixes branch October 10, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants