Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(td-tools): AID idShort does not allow ":" and uses "_" instead #1113

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

danielpeintner
Copy link
Member

fixes #1112

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1f71e3f) 75.71% compared to head (99c181d) 75.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1113      +/-   ##
==========================================
+ Coverage   75.71%   75.77%   +0.06%     
==========================================
  Files          80       80              
  Lines       16108    16114       +6     
  Branches     1507     1509       +2     
==========================================
+ Hits        12196    12211      +15     
+ Misses       3874     3864      -10     
- Partials       38       39       +1     
Files Coverage Δ
...s/td-tools/src/util/asset-interface-description.ts 83.26% <84.61%> (+1.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielpeintner danielpeintner changed the title refactor(td-tools): AID idShort does not allow ":" and used "_" instead refactor(td-tools): AID idShort does not allow ":" and uses "_" instead Oct 12, 2023
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this column problem is interesting... it means that basically, it would not allow any extension to the TD (i.e., importing other ontologies, etc.)

@danielpeintner
Copy link
Member Author

this column problem is interesting... it means that basically, it would not allow any extension to the TD (i.e., importing other ontologies, etc.)

There are other means in place/planned but I agree, this is somewhat limiting but from the implementation point of view we cannot do much about it...

@danielpeintner danielpeintner merged commit 63b31c6 into eclipse-thingweb:master Oct 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AID does not allow colons (i.e., :) in idShort
2 participants