Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readme #1114

Merged
merged 15 commits into from
Oct 13, 2023
Merged

Improve readme #1114

merged 15 commits into from
Oct 13, 2023

Conversation

relu91
Copy link
Member

@relu91 relu91 commented Oct 12, 2023

This PR tries to improve the main node-wot readme to provide more background information and easier to follow structure. It also adds the Thingweb logo at the top of the readme. Feel free to suggest any changes.

@relu91
Copy link
Member Author

relu91 commented Oct 12, 2023

Two issues:

  1. image
  2. webpack config file that I need to remove (sorry it was in another branch)

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1f71e3f) 75.71% compared to head (e8ba7c6) 75.67%.
Report is 25 commits behind head on master.

❗ Current head e8ba7c6 differs from pull request most recent head f5a5b6a. Consider uploading reports for the commit f5a5b6a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1114      +/-   ##
==========================================
- Coverage   75.71%   75.67%   -0.04%     
==========================================
  Files          80       80              
  Lines       16108    16159      +51     
  Branches     1507     1520      +13     
==========================================
+ Hits        12196    12229      +33     
- Misses       3874     3888      +14     
- Partials       38       42       +4     

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@relu91
Copy link
Member Author

relu91 commented Oct 12, 2023

Just rebased removing the webpack file. I also fixed the logo 👍🏻

CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Cristiano Aguzzi <[email protected]>
@danielpeintner danielpeintner merged commit b44448b into eclipse-thingweb:master Oct 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants