-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies, skip mbus tests under Windows, use Node 22 in CI #1302
Upgrade dependencies, skip mbus tests under Windows, use Node 22 in CI #1302
Conversation
Co-Authored-By: Jan Romann <[email protected]>
460bef7
to
4a4a31f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Jan! I think this is the best way forward. At least it unblocks us and we can continue the development!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Usually I like to "separate" concerns.
Anyhow, maybe in this case it is time to be pragmatic and to move on 🙃
Thank you Jan!
FYI: I created #1303 to keep track of the mbus problem |
This PR combines some of the changes also present in the PRs #1297 and #1274 to partially resolve the failing tests we are currently experiencing by upgrading some of the dependencies and skipping the Mbus tests in the CI under Windows. It also adds Node 22 to the CI matrix.
If this PR should get merged, we should probably create a follow-up issue for continuing the work on resolving the Mbus problem.
Closes #1297, closes #1274, closes #1292.