AAS error handling #514
AAS error handling #514
Conversation
✅ Deploy Preview for thingweb-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Implemented minor fixes with the new close tab prompt, so that if a user opens an example while the close prompt is open, it will close the prompt. |
|
Momentarily removed the "Save as" button until HTTPS is implemented for Playground |
| @@ -198,6 +196,15 @@ function enableAPIConversionWithProtocol(editorInstance) { | |||
| showConsoleError("Please insert a TD which uses MQTT!") | |||
| } | |||
| } | |||
|
|
|||
| if (AASTab.checked === true) { | |||
| if (["mqtt", "mqtts", "http", "https", "coap", "modbus"].some(p => protocolSchemes.includes(p))) { | |||
There was a problem hiding this comment.
Why is this check there, we should not limit it to protocols we are aware of... makes it also difficult to maintain in the future.
There was a problem hiding this comment.
The idea is to align them like other tabs (asyncapi, openapi). Ideally, all thr modules should have the same programming api to report back but it's not the case atm
There was a problem hiding this comment.
So I have done some tests with even BACnet and the transformation still works. We are not able to really test them though (since there is no BACnet AID) so I would be still leaning to not accept unknown protocols. What is your opinion @danielpeintner about that? Will node-wot reject an unknown protocol in the future or will it try best effort?
I guess it would be wrong to reject unknown protocols. The current node-wot code does not make any assumption. Hence I agree with your statement "we should accept unknown protocols" |
But shouldn't we at least give a warning? It feels a bit wrong to be confident about something that doesn't "exist" |
I don't feel strongly about it and a warning might be okay. |
| generateAAS(editorInstance["_domElement"].dataset.modeId, editorInstance) | ||
| AASView.classList.remove("hidden") | ||
| } else { | ||
| showConsoleError("Please insert a TD which uses HTTP, MQTT, CoAP or Modbus!") |
There was a problem hiding this comment.
So this should be changed since all protocols technically work. @SergioCasCeb could you remove the error and only display `Protocols other than HTTP, MQTT and Modbus are not officially supported by AID, do not use the resulting AID in production" on the bottom of the JSON button?
There are plans to add protocol validation and this will indeed be a question. So far |
Removed the protocol error message, and substituted it for a general warning message in the input section on top of the download button
|
@danielpeintner what do you think now? It is only a gray text on the right hand side |
Fine by me |
Added a similar error handling and message just like the ones utilized for OpenAPI and AsyncAPI.