Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ESlint issues with the web-new package #570

Merged

Conversation

SergioCasCeb
Copy link
Contributor

  • Solved all remaining issues in my scripts, and test that were causing the ESlint test to fail
  • Modified the eslinrc.json file to a slightly newer version which accepts the spread operator
  • As well as adding "sourceType": "module" to the parserOptions to accept "module" scripts

Also @egekorkan is there a reason to why we are utilizing such an old version (8 / 2017) of ESlint, or should we bump it up to the 2013 or 2014 versions?

…rc.json file to a slightly newer version and to accept "module" scripts
Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for thingweb-playground ready!

Name Link
🔨 Latest commit 138cf60
🔍 Latest deploy log https://app.netlify.com/sites/thingweb-playground/deploys/66036309d621da000801a1e1
😎 Deploy Preview https://deploy-preview-570--thingweb-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@egekorkan
Copy link
Member

Also @egekorkan is there a reason to why we are utilizing such an old version (8 / 2017) of ESlint, or should we bump it up to the 2013 or 2014 versions?

No reason, probably stayed around and we didn't change it

@SergioCasCeb
Copy link
Contributor Author

No reason, probably stayed around and we didn't change it

So there is not issue if I bump it up to the latest version right?

Also I still don't fully understand why the web-new test fails in the Default CI & CD Pipeline fails

@egekorkan
Copy link
Member

So there is not issue if I bump it up to the latest version right?

Yes, please do so :)

Also I still don't fully understand why the web-new test fails in the Default CI & CD Pipeline fails

The errors are really confusing since it mixes up web and webnew for some reason. Does it work in your machine?

@egekorkan egekorkan merged commit 908cd96 into eclipse-thingweb:master Apr 5, 2024
10 of 12 checks passed
@SergioCasCeb SergioCasCeb deleted the ESlint-web-new-fixes branch April 18, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants