Skip to content

Commit

Permalink
Fix debounce with void events (#269)
Browse files Browse the repository at this point in the history
  • Loading branch information
yumauri authored Feb 2, 2023
1 parent 81d4baa commit 8b6cc70
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 2 deletions.
14 changes: 14 additions & 0 deletions src/debounce/debounce.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -569,3 +569,17 @@ test('debounce do not affect another instance of debounce', async () => {
await wait(20);
expect(watcherSecond).toBeCalledWith('foo');
});

test('debounced event should be triggered with undefined', async () => {
const trigger = createEvent();
const debounced = debounce({ source: trigger, timeout: 0 });

const listener = jest.fn();
debounced.watch(listener);

trigger();
await wait(0);

expect(listener).toBeCalledTimes(1);
expect(listener).toBeCalledWith(undefined);
});
5 changes: 3 additions & 2 deletions src/debounce/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@ export function debounce<T>({
$timeoutId.reset(timerFx.done);

// It's ok - nothing will ever start unless source is triggered
const $payload = createStore<T>(null as unknown as T, { serialize: 'ignore' }).on(
const $payload = createStore<T[]>([], { serialize: 'ignore' }).on(
source,
(_, payload) => payload,
(_, payload) => [payload],
);

const $canTick = createStore(true, { serialize: 'ignore' });
Expand Down Expand Up @@ -130,6 +130,7 @@ export function debounce<T>({
sample({
source: $payload,
clock: timerFx.done,
fn: ([payload]) => payload,
target: tick,
});

Expand Down

1 comment on commit 8b6cc70

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚛 size-compare report

Comparing 81d4baa3...8b6cc700

File +/- Base Current +/- gzip Base gzip Current gzip
dist/and/index.cjs = 397 B 397 B = 251 B 251 B
dist/and/index.js = 413 B 413 B = 245 B 245 B
dist/babel-preset.cjs = 434 B 434 B = 249 B 249 B
dist/combine-events/index.cjs = 2.46 kB 2.46 kB = 840 B 840 B
dist/combine-events/index.js = 3.95 kB 3.95 kB = 1.35 kB 1.35 kB
dist/condition/index.cjs = 1.37 kB 1.37 kB = 505 B 505 B
dist/condition/index.js = 1.29 kB 1.29 kB = 461 B 461 B
dist/debounce/index.cjs +0.86% 3.96 kB 3.99 kB +1.32% 1.29 kB 1.31 kB
dist/debounce/index.js +2.26% 3.76 kB 3.84 kB +2.38% 1.26 kB 1.29 kB
dist/debug/index.cjs = 11.3 kB 11.3 kB = 3.16 kB 3.16 kB
dist/debug/index.js = 13.3 kB 13.3 kB = 3.79 kB 3.79 kB
dist/delay/index.cjs = 1.76 kB 1.76 kB = 708 B 708 B
dist/delay/index.js = 1.81 kB 1.81 kB = 702 B 702 B
dist/either/index.cjs = 600 B 600 B = 334 B 334 B
dist/either/index.js = 477 B 477 B = 270 B 270 B
dist/empty/index.cjs = 175 B 175 B = 151 B 151 B
dist/empty/index.js = 79 B 79 B = 89 B 89 B
dist/equals/index.cjs = 336 B 336 B = 249 B 249 B
dist/equals/index.js = 221 B 221 B = 179 B 179 B
dist/every/index.cjs = 1.22 kB 1.22 kB = 513 B 513 B
dist/every/index.js = 1.08 kB 1.08 kB = 442 B 442 B
dist/format/index.cjs = 642 B 642 B = 366 B 366 B
dist/format/index.js = 687 B 687 B = 368 B 368 B
dist/in-flight/index.cjs = 641 B 641 B = 357 B 357 B
dist/in-flight/index.js = 546 B 546 B = 305 B 305 B
dist/index.cjs = 1.57 kB 1.57 kB = 359 B 359 B
dist/index.js = 1.09 kB 1.09 kB = 279 B 279 B
dist/interval/index.cjs = 3.88 kB 3.88 kB = 1.14 kB 1.14 kB
dist/interval/index.js = 3.74 kB 3.74 kB = 1.12 kB 1.12 kB
dist/macro.cjs = 1.91 kB 1.91 kB = 808 B 808 B
dist/not/index.cjs = 161 B 161 B = 148 B 148 B
dist/not/index.js = 69 B 69 B = 81 B 81 B
dist/or/index.cjs = 393 B 393 B = 249 B 249 B
dist/or/index.js = 411 B 411 B = 245 B 245 B
dist/patronum.cjs +0.06% 18.7 kB 18.7 kB +0.30% 5.91 kB 5.93 kB
dist/patronum.js +0.15% 17.7 kB 17.8 kB +0.42% 5.99 kB 6.01 kB
dist/patronum.umd.js +0.06% 19.8 kB 19.8 kB +0.35% 6.02 kB 6.04 kB
dist/pending/index.cjs = 909 B 909 B = 495 B 495 B
dist/pending/index.js = 828 B 828 B = 444 B 444 B
dist/reset/index.cjs = 324 B 324 B = 208 B 208 B
dist/reset/index.js = 249 B 249 B = 157 B 157 B
dist/reshape/index.cjs = 419 B 419 B = 242 B 242 B
dist/reshape/index.js = 379 B 379 B = 201 B 201 B
dist/snapshot/index.cjs = 756 B 756 B = 346 B 346 B
dist/snapshot/index.js = 641 B 641 B = 288 B 288 B
dist/some/index.cjs = 1.16 kB 1.16 kB = 474 B 474 B
dist/some/index.js = 1.02 kB 1.02 kB = 407 B 407 B
dist/split-map/index.cjs = 628 B 628 B = 359 B 359 B
dist/split-map/index.js = 575 B 575 B = 318 B 318 B
dist/spread/index.cjs = 1.26 kB 1.26 kB = 534 B 534 B
dist/spread/index.js = 1.28 kB 1.28 kB = 516 B 516 B
dist/status/index.cjs = 426 B 426 B = 265 B 265 B
dist/status/index.js = 339 B 339 B = 208 B 208 B
dist/throttle/index.cjs = 2.1 kB 2.1 kB = 814 B 814 B
dist/throttle/index.js = 1.99 kB 1.99 kB = 775 B 775 B
dist/time/index.cjs = 719 B 719 B = 375 B 375 B
dist/time/index.js = 621 B 621 B = 321 B 321 B

Please sign in to comment.