feat: allow worker listen different port to support nginx sticky #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killagu
force-pushed
the
feat/nginx-sticky
branch
from
e814ca4
to
d7f86a5
Compare
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
- Coverage 98.81% 98.46% -0.36%
==========================================
Files 8 8
Lines 507 520 +13
==========================================
+ Hits 501 512 +11
- Misses 6 8 +2
Continue to review full report at Codecov.
|
killagu
force-pushed
the
feat/nginx-sticky
branch
from
e517270
to
7127c43
Compare
ngot
reviewed
Jul 26, 2019
| this[WORKER_ADDRESSES].push(address); | ||
| } else { | ||
| address.port = this.options.sticky ? this[REAL_PORT] : address.port; | ||
| this[APP_ADDRESS] = getAddress(address); | ||
| } |
| to: 'master', | ||
| from: 'app', | ||
| }); | ||
| }); |
There was a problem hiding this comment.
send port to master after egg ready and before server listen.
| port, | ||
| protocol, | ||
| }, | ||
| }); |
| const stickyMsg = this.options.sticky ? ' with STICKY MODE!' : ''; | ||
| this.logger.info('[master] %s started on %s (%sms)%s', | ||
| frameworkPkg.name, this[APP_ADDRESS], Date.now() - startTime, stickyMsg); | ||
| } | ||
|
|
There was a problem hiding this comment.
What's the different between nginxSticky and sticky? Seems they are mixed together.
There was a problem hiding this comment.
nginxSticky: nginx -> app-workersticky: nginx -> master -> app-worker
|
@ngot Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change