Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get FileTransport file #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mytEcust
Copy link

@mytEcust mytEcust commented Mar 2, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@@ -36,6 +36,10 @@ class FileTransport extends Transport {
});
}

get file() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个接口不太合理。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filePath ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mytEcust 具体是什么需求?目前不加 getter 可以通过 options.file 获取到。

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (5417064) 98.69% compared to head (a0680a7) 98.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          14       14           
  Lines        1300     1304    +4     
  Branches      214      215    +1     
=======================================
+ Hits         1283     1287    +4     
  Misses         17       17           
Impacted Files Coverage Δ
lib/transports/file.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants