-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xpack][metricbeats][gcp] don't skip first value in histogram calculations #41822
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
@stefans-elastic : Thanks for the change. |
good point, thanks |
Proposed commit message
Don't skip first value in histogram upper bound calculations.
This should be done because according to GCP doc (https://cloud.google.com/monitoring/api/ref_v3/rpc/google.api) the histogram (Exponential and Linear) upper bound should include bucket values at index 0.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Closes #
Use cases
Screenshots
Here is screenshot from local test -
values
seem to be okLogs