Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xpack][metricbeats][gcp] don't skip first value in histogram calculations #41822

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

stefans-elastic
Copy link

Proposed commit message

Don't skip first value in histogram upper bound calculations.

This should be done because according to GCP doc (https://cloud.google.com/monitoring/api/ref_v3/rpc/google.api) the histogram (Exponential and Linear) upper bound should include bucket values at index 0.
Screenshot 2024-11-28 at 3 18 09 PM
Screenshot 2024-11-28 at 3 18 47 PM

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Closes #

Use cases

Screenshots

Here is screenshot from local test - values seem to be ok
Screenshot 2024-11-28 at 1 28 11 PM

Logs

@stefans-elastic stefans-elastic requested review from a team as code owners November 28, 2024 13:27
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 28, 2024
Copy link
Contributor

mergify bot commented Nov 28, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @stefans-elastic? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Nov 28, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 28, 2024
@gpop63 gpop63 added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team label Dec 2, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 2, 2024
@gpop63 gpop63 added Team:obs-ds-hosted-services Label for the Observability Hosted Services team needs_team Indicates that the issue/PR needs a Team:* label labels Dec 2, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 2, 2024
@ishleenk17
Copy link
Contributor

@stefans-elastic : Thanks for the change.
Can we also update the sample json here.

@stefans-elastic
Copy link
Author

@stefans-elastic : Thanks for the change. Can we also update the sample json here.

good point, thanks
updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:obs-ds-hosted-services Label for the Observability Hosted Services team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants