Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick improvement for analytics reporting #8773

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Mar 8, 2024

Quick improvement on Analytics for posthog that would allow us to better filter reported decryption errors.

This is adding the following properties to all events:
appVersion: similar to what web is doing.
applicationId: the package id
appFlavor: the flavor (googlePlay / FDroid)
cryptoSDK: Parity with web, to allow to use common filters.

Also adding a specific property for E2E domain errors, that are not common to all platforms (is_cross_signed_verified).

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@BillCarsonFr BillCarsonFr requested a review from bmarty March 8, 2024 09:59
@BillCarsonFr BillCarsonFr marked this pull request as draft March 8, 2024 11:11
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I have done a cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants