Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable key backup by default #28267

Closed
wants to merge 10 commits into from
Closed

Enable key backup by default #28267

wants to merge 10 commits into from

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Oct 22, 2024

When we set up cross signing, so the key backup key will be stored locally along with the cross signing keys until the user sets up recovery (4s). This will mean that a user can restore their backup if they log in on a new device as long as they verify with the one they registered on.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

When we set up cross signing, so the key backup key will be stored
locally along with the cross signing keys until the user sets up
recovery (4s). This will mean that a user can restore their backup
if they log in on a new device as long as they verify with the one
they registered on.
dbkr added 2 commits December 2, 2024 15:08
so test passes again
Being able to upload keys without any auth works too, so return true.
Otherwise we have to go the same route via the InteractiveAuthDialog
which is way more complex.
dbkr added a commit that referenced this pull request Dec 9, 2024
When we set up cross signing, so the key backup key will be stored locally along with the cross signing keys until the user sets up recovery (4s). This will mean that a user can restore their backup if they log in on a new device as long as they verify with the one they registered on.

Replaces #28267
@dbkr dbkr mentioned this pull request Dec 9, 2024
4 tasks
@dbkr
Copy link
Member Author

dbkr commented Dec 9, 2024

superseeded by #28691

@dbkr dbkr closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant