Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#28285 issue: Update _EventTile.pcss #28604

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

captainspeedy68
Copy link

Checklist

  • Linter and other CI checks pass.

PR Description

  • Updated .mx_EventTile_e2eIcon_normal to support custom fallback colors for the var() function.
  • Linter check has been run locally and passed successfully.

Notes

  • I have not run the full CI checks but would appreciate feedback to ensure everything aligns with project standards.

@captainspeedy68 captainspeedy68 requested a review from a team as a code owner December 1, 2024 17:19
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Dec 1, 2024
Copy link
Member

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I don't think that the issue here is the fallback colour. The grey comment indicates that the --cpd-color-icon-tertiary token is grey. As you can see in our css tokens.

I'm checking with the design team to know which background colour should be used here.

@t3chguy
Copy link
Member

t3chguy commented Dec 2, 2024

Please give the PR a descriptive title, the current title will make no sense to anyone in the changelogs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants