Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid can't build #3420

Closed
licaon-kter opened this issue Sep 6, 2024 · 20 comments
Closed

F-Droid can't build #3420

licaon-kter opened this issue Sep 6, 2024 · 20 comments
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@licaon-kter
Copy link

licaon-kter commented Sep 6, 2024

Steps to reproduce

ref: https://gitlab.com/fdroid/fdroiddata/-/jobs/7763982630#L6856

diff log: elx40005021.log see line 33?

we are using this one weird trick in the recipe: https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/io.element.android.x.yml#L40

so you don't have main there now? remember #1418 (comment)

Outcome

.

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

Yes

Are you willing to provide a PR?

No

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/56269f5965ec1a9e1feb20192bfd74d333cb7300

@licaon-kter licaon-kter added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Sep 6, 2024
@bmarty
Copy link
Member

bmarty commented Sep 9, 2024

The gitBranchName has been moved (in #3381) and is now set here: https://github.com/element-hq/element-x-android/blob/main/app/build.gradle.kts#L301

    val gitBranchName = providers.of(GitBranchNameValueSource::class.java) {}.get()

I guess the trick at https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/io.element.android.x.yml#L40 need to be updated to alter this line instead, and the result will be

    val gitBranchName = "main"

@linsui
Copy link

linsui commented Sep 9, 2024

diff.zip

The branch name patch has been update. The current problem is that two classes have different order. I have tried to build it many times with different cpu core numbers and the result never changed. I thought there is difference between the github ubuntu runner and our debian VM.

@bmarty
Copy link
Member

bmarty commented Sep 9, 2024

There is no way to "ignore" that difference?

@linsui
Copy link

linsui commented Sep 9, 2024

No, we can't ignore it. We have to fix it.

@licaon-kter
Copy link
Author

wow, so close

   --- ElementXAndroidv0.6.0_armv7/smali/io/element/android/x/di/AppComponent.smali
── +++ io.element.android.x_40006001/smali/io/element/android/x/di/AppComponent.smali
┄ Ordering differences only
 @@ -1,15 +1,15 @@
  .class public interface abstract Lio/element/android/x/di/AppComponent;
  .super Ljava/lang/Object;
  .source "SourceFile"
  
  # interfaces
  .implements Lio/element/android/libraries/architecture/NodeFactoriesBindings;
 -.implements Lio/element/android/x/di/AppBindings;
  .implements Lio/element/android/x/di/SessionComponent$ParentBindings;
 +.implements Lio/element/android/x/di/AppBindings;
  .implements Lio/element/android/features/cachecleaner/api/CacheCleanerBindings;
  .implements Lio/element/android/libraries/pushproviders/unifiedpush/VectorUnifiedPushMessagingReceiverBindings;
  .implements Lio/element/android/features/call/impl/di/CallBindings;
  .implements Lio/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiverBindings;
  .implements Lio/element/android/libraries/push/impl/notifications/TestNotificationReceiverBinding;
  .implements Lio/element/android/features/lockscreen/impl/unlock/di/PinUnlockBindings;
  
 @@ -24,16 +24,16 @@
  .annotation runtime Lkotlin/Metadata;
      d1 = {
          "\u00000\n\u0002\u0018\u0002\n\u0002\u0018\u0002\n\u0002\u0018\u0002\n\u0002\u0018\u0002\n\u0002\u0018\u0002\n\u0002\u0018\u0002\n\u0002\u0018\u0002\n\u0002\u0010\u0000\n\u0002\u0018\u0002\n\u0002\u0018\u0002\n\u0002\u0018\u0002\n\u0002\u0008\u0002\u0008g\u0018\u00002\u00020\u00012\u00020\u00022\u00020\u00032\u00020\u00042\u00020\u00052\u00020\u00062\u00020\u00072\u00020\u00082\u00020\t2\u00020\n:\u0001\u000b\u00a8\u0006\u000c"
      }
      d2 = {
          "Lio/element/android/x/di/AppComponent;",
          "Lio/element/android/libraries/architecture/NodeFactoriesBindings;",
 -        "Lio/element/android/x/di/AppBindings;",
          "Lio/element/android/x/di/SessionComponent$ParentBindings;",
 +        "Lio/element/android/x/di/AppBindings;",
          "Lio/element/android/features/cachecleaner/api/CacheCleanerBindings;",
          "Lio/element/android/libraries/pushproviders/unifiedpush/VectorUnifiedPushMessagingReceiverBindings;",
          "Lio/element/android/features/call/impl/di/CallBindings;",
          "",
          "Lio/element/android/libraries/push/impl/notifications/NotificationBroadcastReceiverBindings;",
          "Lio/element/android/libraries/push/impl/notifications/TestNotificationReceiverBinding;",
          "Lio/element/android/features/lockscreen/impl/unlock/di/PinUnlockBindings;",

@bmarty
Copy link
Member

bmarty commented Sep 18, 2024

Good to see the progress, thanks @licaon-kter !

We have release 0.6.2 on the PlayStore: https://github.com/element-hq/element-x-android/releases/tag/v0.6.2, if you want to try again the F-Droid build using this version...

@bmarty bmarty pinned this issue Sep 18, 2024
@licaon-kter
Copy link
Author

started a build, brb

@licaon-kter
Copy link
Author

@bmarty no change, same diff :(

@wrenix
Copy link

wrenix commented Sep 19, 2024

nothing changes to v0.6.3 ? i do not set any commit related to build process

@licaon-kter
Copy link
Author

Nothing new, no

@xundeenergie
Copy link

Sorry comment in wrong thread.

@kugelzucker
Copy link

Is there any progress on this? Really don't want to use the play version.

@licaon-kter
Copy link
Author

@kugelzucker use the Github releases in the meantime :)

@wrenix
Copy link

wrenix commented Oct 10, 2024

In the release v0.6.5 are many build related ... Get it more worst?

@licaon-kter
Copy link
Author

licaon-kter commented Oct 10, 2024

0.6.5 is underway 🎇 😉

@wrenix
Copy link

wrenix commented Oct 11, 2024

You are right it looks well: https://monitor.f-droid.org/builds/log/io.element.android.x/40006051#site-footer

thank you.

hope it is a stable build process, now.
And do not get broken again (and v0.7.0 get also released fast in fdroid).

@manuroe
Copy link
Member

manuroe commented Oct 11, 2024

thanks @licaon-kter. This is great!
Do you know how low it takes between the CI validation and the availability on https://f-droid.org/en/packages/io.element.android.x/?

@licaon-kter
Copy link
Author

@manuroe the link above is not the CI validation, but the main server. Fyi: https://gitlab.com/fdroid/wiki/-/wikis/FAQ#how-long-does-it-take-for-my-app-to-show-up-on-website-and-client

@wrenix
Copy link

wrenix commented Oct 15, 2024

The Build of v0.7.0 for arm64 failed:
https://monitor.f-droid.org/builds/log/io.element.android.x/40007002

@licaon-kter
Copy link
Author

licaon-kter commented Oct 15, 2024

trying to build locally fails even earlier as: io.element.android.x_40007002.log.gz

I've removed my local cloned repo and I'm retrying 🤷

/LE: more info in: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/16030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

7 participants