-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename AppBindings to XAppBindings #3518
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3518 +/- ##
========================================
Coverage 82.67% 82.67%
========================================
Files 1731 1731
Lines 40863 40863
Branches 4971 4971
========================================
Hits 33785 33785
Misses 5315 5315
Partials 1763 1763 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's kind of sad we have to workaround this, but let's try it out 🥲 .
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this doesn't fix the issue for reproducible builds, so there's no point in the rename... Thanks for trying to fix it, though.
Rename AppBindings to XAppBindings to attempt to fix reproducible build issue
Attempt to fix difference reported here: #3420 (comment)
If this does not work, we may want to move
XAppBindings
to a sub package...