-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOOD-23 Input $$ as an argument for price range #24
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CircleCI says there are failing tests
Please assign @njbarber as a reviewer as well. |
CircleCI still failing. You can run |
is_valid = False | ||
is_invalid = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
y tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extra argument means there's logic changes in how we look at the command. Its simpler to say that the command is valid and must be proven otherwise, than to assume it's wrong and must be proven valid.
Can we change it so users can instead pass in a number representing the highest dollar amount they are willing to spend rather than |
@mdang8 we could do that, but then we would have two numerical arguments and no real way to convey the order of the arguments. Also, we couldn't set the price range unless we set the choices first. I do have the API work with actual numbers in the parameters, though. Also, I |
What does this PR do?
Gimme eat with $money$
Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged)?
@aaronilovici
@aperullo
@cjlange
@josephthweatt
@mdang8
@oconnormi
@pvargas
@rfding
@njbarber
How should this be tested? (List steps with links to updated documentation)
Enter in five dollar signs as an argument. Ensure that a fancy restaurant is recommended. Go to restaurant to confirm assessed swankiness.
Any background context you want to provide?
$$$$$$$$$
What are the relevant tickets?
Fixes #23
Screenshots (if appropriate)
Checklist: