Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide a custom variable for typeCheckingMode #104

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

kassick
Copy link
Contributor

@kassick kassick commented Oct 11, 2024

No description provided.

@seagle0128 seagle0128 merged commit 327edce into emacs-lsp:master Oct 11, 2024
11 checks passed
@wyuenho
Copy link
Contributor

wyuenho commented Oct 11, 2024

I specifically removed this in #96 , why'd you put it back? You are supposed to configure this settings in your pyproject.toml or pyrightconfig.json file, otherwise directly setting it when connecting to the server will override the project setting.

@kassick
Copy link
Contributor Author

kassick commented Oct 11, 2024

In pyright (and basedpyright too), if you define typeCheckingMode in your pyproject.toml, the custom variable will be ignored (at least that's what I observed here in a quick test), so having the custom variable should not be an issue if you want to have per-project values.

The custom variable is specially useful with basedpyright -- the default is "all", which is quite overwhelming in the editor.

@wyuenho
Copy link
Contributor

wyuenho commented Oct 11, 2024

I see, the situation seems to have changed shortly after I've removed all these duplicate settings.

@kassick
Copy link
Contributor Author

kassick commented Oct 11, 2024

Ah, I see -- having this setting in the editor overriding the ones in the config file is indeed bad, I see now why the previous PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants