Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Node 14 #1246

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Drop support for Node 14 #1246

wants to merge 4 commits into from

Conversation

mansona
Copy link
Member

@mansona mansona commented Aug 30, 2023

I had originally intended to get a release out before we dropped support for node 14 but #1194 will be part of the next release and it is already breaking, so we might as well drop Node 14 support here too 👍

@mansona mansona requested a review from a team August 30, 2023 15:42
22a
22a previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@22a 22a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ef4 ef4 mentioned this pull request Sep 5, 2023
Open
@ef4
Copy link

ef4 commented Sep 5, 2023

@mansona I have CI green using patch-package in #1247.

My suspicion was correct that npx has concurrency bugs in its cache.

@mansona mansona mentioned this pull request Oct 31, 2023
Open
@ef4 ef4 dismissed 22a’s stale review December 12, 2023 16:08

Still blocked upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@22a 22a 22a left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mansona @ef4 @22a