Handle non-zero frame origin and selection position onChange #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my application the EGOTextView is offset from the left edge of the screen. This was causing alignment issues with the magnifier, which I've fixed here. I tested this in the demo application by creating the EGOTextView with a frame with origin.x and origin.y set to positive non-zero values.
Before:
After:
In addition, when the text field was edited, the selection information (_selectedRange) was being updated after the attributedString was set. This caused the selection position as monitored in the delegate -egoTextViewDidChange: method to always lag by one character. In -insertText: and -deleteBackward I'm not calling the two steps from -setSelectionRange separately, as the range needs to be set before -setAttributedString: calls the delegate function, but -selectionChanged needs to be called after the string is set. Maybe not the most elegant solution, but it works.