clang-tidy: ignore dynamic_modules/abi.h and test C programs (#37426)

part of #28566 --------- Signed-off-by: Takeshi Yoneda <[email protected]>
envoyproxy · Nov 29, 2024 · d12a9c3 · d12a9c3
1 parent ce11ceb
commit d12a9c3
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 1 deletion.
diff --git a/source/extensions/dynamic_modules/abi.h b/source/extensions/dynamic_modules/abi.h
@@ -2,6 +2,9 @@
 
 // NOLINT(namespace-envoy)
 
+// This is a pure C header, so we can't apply clang-tidy to it.
+// NOLINTBEGIN
+
 // This is a pure C header file that defines the ABI of the core of dynamic modules used by Envoy.
 //
 // This must not contain any dependencies besides standard library since it is not only used by
@@ -127,3 +130,5 @@ void envoy_dynamic_module_on_http_filter_config_destroy(
 #ifdef __cplusplus
 }
 #endif
+
+// NOLINTEND
diff --git a/source/extensions/dynamic_modules/abi_version.h b/source/extensions/dynamic_modules/abi_version.h
@@ -6,7 +6,7 @@ namespace DynamicModules {
 #endif
 // This is the ABI version calculated as a sha256 hash of the ABI header files. When the ABI
 // changes, this value must change, and the correctness of this value is checked by the test.
-const char* kAbiVersion = "cf6fef3e32daba5206ecff01c3569fd4b8d7a07cef6b36822c8e03aeff97fec9";
+const char* kAbiVersion = "332d7c7fbfc7f5af6b48eece62dcb316ae070e389f810ff373e3d3d457d37b5b";
 
 #ifdef __cplusplus
 } // namespace DynamicModules

diff --git a/test/extensions/dynamic_modules/test_data/c/test_data.bzl b/test/extensions/dynamic_modules/test_data/c/test_data.bzl
@@ -10,5 +10,7 @@ def test_program(name):
             "-shared",
             "-fPIC",
         ],
+        # All programs here are C, not C++, so we don't need to apply clang-tidy.
+        tags = ["notidy"],
         linkstatic = False,
     )
diff --git a/tools/spelling/spelling_dictionary.txt b/tools/spelling/spelling_dictionary.txt
@@ -314,6 +314,8 @@ NODATA
 NODELAY
 NODELETE
 NOLINT
+NOLINTBEGIN
+NOLINTEND
 NOLINTNEXTLINE
 NONAME
 NONBLOCK