Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CoreAudio DLL path not being found (on newer Wine?) #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

udf
Copy link

@udf udf commented Feb 24, 2024

FindFirstFile considers a path with a trailing backslash as invalid:

This parameter should not be NULL, an invalid string (for example, an empty string or a string that is missing the terminating null character), or end in a trailing backslash ().

It seems the trailing backslash used to be fine on older versions of Wine, but it has since been fixed.

This could be resolved by trimming the backslash, but I think it's better to use PathFileExists instead, which "Determines whether a path to a file system object such as a file or folder is valid.".

I have not tested the changes on Windows, however (but if the Microsoft Documentation is to be believed then it shouldn't have worked before).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant