Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Apache Storm version to 1.0.2: current latest version #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HeartSaVioR
Copy link

@HeartSaVioR HeartSaVioR commented Aug 26, 2016

Apache Storm 1.0.0+ provides various new features and great performance improvement.
In case of not aware of the change, here is release notes for Apache Storm 1.x version line:

http://storm.apache.org/2016/04/12/storm100-released.html
http://storm.apache.org/2016/05/06/storm101-released.html
http://storm.apache.org/2016/08/10/storm102-released.html

Apache Storm community and ecosystem are moving toward to 1.x version line. Since Squall seems to be amazing sql processing engine built on top of Storm, I'd like to make squall to take benefits for performance improvement with recent version of Storm.
(Storm 1.0.0 includes SQL feature but it's still in incubation step and experimental things. It needs more time and expert contributors to be reached to mature.)

Storm 1.0.2 is the recent version which fixes various critical bugs so this version can be treated as stable for 1.0.x version line.

I tested this patch with quick start: local mode. Please let me know if you want to let me test other stuff like cluster mode or so. If we can see benchmark result between before the patch and after the patch it should be great, but I'm not sure how to do that with Squall.


This change is Reviewable

@HeartSaVioR
Copy link
Author

I missed the test stuff. Storm moved from Logback to Log4j2 at 0.10.0 so TestSuite need be updated to reflect that change.

@HeartSaVioR HeartSaVioR changed the title Bump Apache Storm version to 1.0.2: current latest version [WIP] Bump Apache Storm version to 1.0.2: current latest version Aug 26, 2016
@HeartSaVioR HeartSaVioR force-pushed the upgrade-to-storm-1.0.2 branch from 01623b3 to 7fa0869 Compare August 26, 2016 06:05
@HeartSaVioR HeartSaVioR changed the title [WIP] Bump Apache Storm version to 1.0.2: current latest version Bump Apache Storm version to 1.0.2: current latest version Aug 26, 2016
@HeartSaVioR
Copy link
Author

Fixed, and sbt test passed in local.

cc. @ElSeidy @avitorovic @akathorn

* Storm 1.0.0+ provides various new features and great performance improvement
* Storm 1.0.2 is recent version of Storm 1.x line which fixes various critical bugs
@HeartSaVioR HeartSaVioR force-pushed the upgrade-to-storm-1.0.2 branch from 7fa0869 to 8426c3b Compare August 26, 2016 06:29
@avitorovic
Copy link
Contributor

@HeartSaVioR, Thank you very much for your contribution!

We have an important conference approaching (VLDB 2016) where we will demo Squall. We will demonstrate Squall based on Storm 0.9.4, as we tested it thoroughly, and we would rather not do any last-minute changes. Once the conference passes, we'll be glad to merge your commits.

Thanks again for your contribution!

@HeartSaVioR
Copy link
Author

@avitorovic
Sure! Please take your time. Might be better to have benchmark between 0.9.4 vs 1.0.2 before merging in.
Hope your amazing presentation be crowded. :) Please mention me once the conference passes.

@HeartSaVioR
Copy link
Author

Could we revisit this now?

@avitorovic avitorovic force-pushed the master branch 3 times, most recently from 7e9abc6 to 9b5c9f1 Compare May 18, 2017 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants