-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- use epireview functions to get parameters #305
Conversation
Notes and limitations look great to me. I have a few editing suggestions:
|
Thanks for this contribution @cm401 & @kellymccain28. The {epireview} -> {epiparameter} vignette has change quite a bit since this PR was opened, but I think the updates are still valuable. I think the use of |
- add notes & limitations on review data
5cbd0ff
to
e2fca2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rebase worked so everything is now up-to-date.
I've updated the text with @kellymccain28's suggestions, and I think everything is ready to be merged.
Thanks both for your contribution. Apologies it took so long to get it merged into the package.
NEWS.md
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
In the data_from_epireview vignette we use epireview functions to get and filter parameters
We add notes on epireview data for users.
What is the current behavior? (You can also link to an open issue here)
No change in behaviour.
What is the new behavior (if this is a feature change)?
No change in behaviour.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
@annecori, @patcatgit, @kellymccain28, @ruthmccabe - please review, in particular notes + limitations on epireview.