-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add database vignette #311
Conversation
This pull request:
(Note that results may be inacurrate if you branched from an outdated version of the target branch.) |
Thanks @sbfnk this looks great. I'm happy to move forward with this change and merge into
If we want this to be only on the website and not shipped with the package we could consider converting this from a vignette to an article. We can always change this down the road so happy to merge before we've decided on this point. |
|
This is a nice addition and might be worth evaluating its benefit over the suggested dashboard in #263 or what gap the dashboard would fill that this database doesn't. |
I wasn't sure whether it would render on CRAN, according to this page I think it does: https://cran.r-project.org/web/packages/DT/vignettes/DT.html. I'll leave as a vignette for now and if we think it is better for this to only be on the website and not on CRAN we can convert to an article in a subsequent PR.
I see these two things as positive duplication. There will be some overlap between this vignette and the dashboard, but 1) it doesn't hurt to provide the ability to search through the database in multiple places, 2) the dashboard is still in development and this provides a quick solution, 3) the dashboard will provide more functionality that just searching through the database. |
This pull request:
(Note that results may be inacurrate if you branched from an outdated version of the target branch.) |
1 similar comment
This pull request:
(Note that results may be inacurrate if you branched from an outdated version of the target branch.) |
This pull request:
(Note that results may be inacurrate if you branched from an outdated version of the target branch.) |
Apologies for the spam. It took a few commits to get the lintr workflow to pass. This PR is now ready to be merged. |
Closes #296.
NEWS.md
It adds a prototype for a database vignette
Format etc. can be discussed as well as whether this is desirable to have. Creating this PR as a suggestion for what the database might look like.