Remove on.exit() from plot.epiparameter()
#420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #409 by removing the call to
on.exit()inplot.epiparameter()as the function no longer modifies graphics parameters in the body of the function. This now allows users to plot a matrix of plots using globally set graphics parameters which was being blocked by the use ofon.exit()before.To suppress warnings from
set_state_inspector()I've manually restored the graphics parameters in unit tests that callplot()as calling this function modifies some of the parameters.Plots snapshots are also updated (although the visuals of the plots are unchanged).
par()is no longer called in any functions so the lintr forpar()is turned back on in the.lintrfile.