-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add action to update smoke tests. #1975
base: master
Are you sure you want to change the base?
Conversation
I don't understand the logic !? We want to be able to run the update on our local machine, to update the reference images. |
Updating the smoke tests does not work on windows. We want a PR to be automatically created with updated tests (if necessary): One may then merge this PR with the original to have updated tests. |
.github/workflows/typescript.yml
Outdated
- name: Create Pull Request | ||
id: cpr | ||
uses: peter-evans/create-pull-request@5a6b15373e5788c38d83296b674ad5abea28085c | ||
if: github.event_name == 'push' && (github.ref != 'refs/heads/master' || contains(github.event.head_commit.message, '[deploy test]')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure what to make of this, but it looks like the event_name
triggered is pull_request
and not push
##[debug]Evaluating condition for step: 'Create Pull Request'
##[debug]Evaluating: (success() && (github.event_name == 'push') && ((github.ref != 'refs/heads/master') || contains(github.event.head_commit.message, '[deploy test]')))
##[debug]Evaluating And:
##[debug]..Evaluating success:
##[debug]..=> true
##[debug]..Evaluating Equal:
##[debug]....Evaluating Index:
##[debug]......Evaluating github:
##[debug]......=> Object
##[debug]......Evaluating String:
##[debug]......=> 'event_name'
##[debug]....=> 'pull_request'
##[debug]....Evaluating String:
##[debug]....=> 'push'
##[debug]..=> false
##[debug]=> false
##[debug]Expanded: (true && ('pull_request' == 'push') && ((github['ref'] != 'refs/heads/master') || contains(github['event']['head_commit']['message'], '[deploy test]')))
…nts into AddGithubAction
This reverts commit b034942.
No description provided.