chore: update routine version to 1.1.4 from 1.1.2 #6467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pr should be tested in both go 1.22 & 1.23. |
haiqingchq
force-pushed
the
feature/update-runtine-version
branch
from
cf173c7 to
acb58d3
Compare
iutx
changed the title
haiqingchq
force-pushed
the
feature/update-runtine-version
branch
from
acb58d3 to
498138c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6467 +/- ##
=======================================
Coverage 15.16% 15.16%
=======================================
Files 3674 3674
Lines 376905 376905
=======================================
+ Hits 57145 57162 +17
+ Misses 314301 314280 -21
- Partials 5459 5463 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
iutx
approved these changes
Nov 18, 2024
sfwn
approved these changes
Nov 18, 2024
|
/approve |
erda-bot
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
when we use go 1.23 to run
make prepare, will encounter this problem：#command-line-arguments Link: github.com/timandy/routine/g: invalid reference to runtime.g0internal/core/openapi/legacy/api/generate/generate.go:33: running "go": exit status 1make: *** [prepare] Error 1fix condition for use go 1.22 to run make prepare
timandy/routine@8b58b7d
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @sfwn @iutx
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.