Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add algo descartes(01AI) #490

Merged
merged 6 commits into from
Mar 19, 2024
Merged

add algo descartes(01AI) #490

merged 6 commits into from
Mar 19, 2024

Conversation

xiaoming-01ai
Copy link
Contributor

No description provided.


WORKDIR /home/app
RUN git clone https://github.com/xiaoming-01ai/pydescartes.git
RUN cp pydescartes/py01ai.cpython-310-x86_64-linux-gnu.so ./py01ai.cpython-310-x86_64-linux-gnu.so
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correctly understood that this is not open source?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maumueller Your understanding is correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maumueller Yes, we are not open source yet.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikbern What is your opinion on including non-open-source libraries?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maumueller @erikbern We've observed that qstngt (not open source) is also included in the list, so we believe that descartes should also be considered :)

README.md Outdated
@@ -46,6 +46,7 @@ Evaluated
* [pgvector](https://github.com/pgvector/pgvector) ![https://img.shields.io/github/stars/pgvector/pgvector?style=social](https://img.shields.io/github/stars/pgvector/pgvector?style=social)
* [RediSearch](https://github.com/redisearch/redisearch) ![https://img.shields.io/github/stars/redisearch/redisearch?style=social](https://img.shields.io/github/stars/redisearch/redisearch?style=social)
* [pg_embedding](https://github.com/neondatabase/pg_embedding) ![https://img.shields.io/github/stars/pg_embedding/pg_embedding?style=social](https://img.shields.io/github/stars/neondatabase/pg_embedding?style=social)
* [Descartes(01AI)](https://github.com/01-ai/Descartes.git)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link doesn't work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maumueller OK, We remove the link and add it back after the product is released in the future.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't my intention to remove it. I think you are pointing to the wrong github repo in the link, so please just edit.

@maumueller maumueller merged commit 0f6ad75 into erikbern:main Mar 19, 2024
34 of 42 checks passed
@maumueller
Copy link
Collaborator

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants