Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to the latest release which has some performance improvements. Still fine to keep this in disabled state as it's still slower than many alternatives.
I re-ran the containerized benchmark on an r6i.4xlarge and got these results:
This is about 20% worse than the non-containerized benchmarks running on the same instance, reported here: alexklibisz/elastiknn@ddf637a. Not quite sure why the difference, but I don't have time to diagnose right now. If I had to speculate it's probably because the containerized version runs both ann-benchmarks and the elasticsearch server on one CPU, whereas non-containerized runs elastiknn container on one cpu and ann-benchmarks on the host.