fix error reporting of runner #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an error is reported, container.logs() returns an iterator over lines of bytes. The decode() function should apply to each line, not to the iterator, otherwise we get no logs, but an error message saying there is no decode() function in the iterator. This change follows the same pattern as stream_logs() in the same file.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an error is reported, container.logs() returns an iterator over lines of bytes. The decode() function should apply to each line, not to the iterator, otherwise we get no logs, but an error message saying there is no decode() function in the iterator.
This change follows the same pattern as stream_logs() in the same file.