Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hamming distance test #513

Closed
wants to merge 1 commit into from
Closed

Conversation

C0rWin
Copy link
Contributor

@C0rWin C0rWin commented Apr 16, 2024

No description provided.

Signed-off-by: Artem Barger <[email protected]>
@ankane
Copy link
Contributor

ankane commented Apr 16, 2024

Hi @C0rWin, check out #508.

@C0rWin
Copy link
Contributor Author

C0rWin commented Apr 16, 2024

Hi @C0rWin, check out #508.

I might be missing something, but master still has this issue:

distance=lambda a, b: np.mean(a.astype(np.bool_) ^ b.astype(np.bool_)),

@ankane
Copy link
Contributor

ankane commented Apr 16, 2024

That code is correct for the benchmarks to show the correct recall with the hosted datasets (see the linked issue or test it yourself).

@C0rWin C0rWin closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants