Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vsag library #549

Merged
merged 1 commit into from
Oct 29, 2024
Merged

add vsag library #549

merged 1 commit into from
Oct 29, 2024

Conversation

wxyucs
Copy link
Contributor

@wxyucs wxyucs commented Oct 21, 2024

add vsag library, and also fixes: #547

ann_benchmarks/main.py Outdated Show resolved Hide resolved
@maumueller
Copy link
Collaborator

Thanks for the contribution @wxyucs. Please also add your implementation to the CI.

@wxyucs
Copy link
Contributor Author

wxyucs commented Oct 22, 2024

Thanks for the contribution @wxyucs. Please also add your implementation to the CI.

@maumueller Already done, please take a look.

@maumueller
Copy link
Collaborator

Thanks for the updates. Could you confirm that the CI is failing for your implementation due to the necessary SIMD/AVX operations not being present on the CI server?

@erikbern
Copy link
Owner

Looks like it's passing now – great

@wxyucs
Copy link
Contributor Author

wxyucs commented Oct 28, 2024

Hi @maumueller, we fixed the issue that pyvsag cannot run on some platforms without SIMD/AVX instructions. And now the CI test for pyvsag is passed.

@maumueller maumueller merged commit 266b14f into erikbern:main Oct 29, 2024
32 of 47 checks passed
@maumueller
Copy link
Collaborator

Thanks for the contribution!

@wxyucs
Copy link
Contributor Author

wxyucs commented Oct 30, 2024

Hi @maumueller, I saw that this pull request has been merged. Is that any plan for running the new algorithm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug report] about the mem_limit of dockers
3 participants