All subclasses of OCMockObject should get stopMocking called on them in dealloc
#497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m as part of dealloc. This seems like a reasonable expectation of the API and in our case enables code that depends on stopMocking to function with OCProtocolMockObjects.
erikdoe
reviewed
Oct 14, 2021
| [stubs release]; | ||
| [expectations release]; | ||
| [exceptions release]; | ||
| [invocations release]; |
There was a problem hiding this comment.
What is the purpose of not releasing the invocations array?
There was a problem hiding this comment.
I believe it happens in -stopMocking and that I probably thought this was redundant.
There was a problem hiding this comment.
As far as I can tell this is the only place.
Removing it here would leak the invocations.
No need to fix on your end, I'll do it while merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a reasonable expectation of the API and in our case enables code that
depends on stopMocking to function with OCProtocolMockObjects.