Support clustered environments #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see how this is readable, though. |
|
the code or the issue? what is unreadable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run in to a "fatal" issue using staticify in clustered server setup. When rolling a new version to the cluster, different nodes can serve different versions of the application. This means one node might serve asset with hash "1a" and another might have the same asset with updated version and serving it with hash "1b". The client might get the hashed URL from new node with hash "1b", but requesting it would go to the old node having the "1a" version. Staticify will happily serve the "1a" content with the "1b" request as if it is correct version and it gets cached in reverse proxy for one year. This breaks the application quite effectively.
In this PR the hash is stored to "versions" and on request the hash is checked to match or maxAge=0 will be served to disable reverse proxy caching.