test: Fix types test #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasttime
reviewed
Dec 5, 2024
tests/types/types.test.ts
Outdated
Comment on lines
4
to
5
| css satisfies ESLint.Plugin; | ||
| // TODO: Uncomment when ESLint.Plugin can accept non-JS rules | ||
| // css satisfies ESLint.Plugin; |
There was a problem hiding this comment.
I'm not sure this change is necessary. It looks like the type test is passing. We can always comment out the failing parts of the test in a PR if it's necessary to add a new rule. And I will have a look at eslint/eslint#19157 soon so we can get type support for non-JS rules in the main repo.
|
Another issue that I ran into with test is that we need to be sure |
fasttime
previously approved these changes
Dec 6, 2024
fasttime
added
the
accepted
Co-authored-by: Francesco Trotta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Fix the types test.
What changes did you make? (Give an overview)
Commented out the test to verify that the plugin satisfiesESLint.Plugin. This can't happen becauseESLint.Pluginrules aren't yet updated to match language plugin rules type.Ensure that
npm run buildis always run before the types test.Related Issues
Is there anything you'd like reviewers to focus on?