v3 Climate Component #86
Conversation
✅ Deploy Preview for esphome-webserver ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mattsgreen
changed the title
| if ( | ||
| e?.currentTarget?.domain === "sensor" || | ||
| e?.currentTarget?.domain === "climate" | ||
| ) { |
There was a problem hiding this comment.
Not important and not certain if this code is being transpiled, but if it is, a bit of redundant code can be reduced by doing something like if (!e?.currentTarget) return; as the first line within this function. That way we're not repeatedly checking and ensuring that e and currentTarget exists (if it does the first time, it will the next n times). Then also TS shouldn't require ? for each reference (e?.currentTarget?... -> e.currentTarget...).
I know this wasn't you, but a good opportunity for tiny clean up if you're willing.
| let targetTemp = | ||
| target === "high" | ||
| ? entity.target_temperature_high | ||
| : entity.target_temperature || entity.target_temperature_low; |
There was a problem hiding this comment.
One small improvement might be caching this choice to something like const lowTemp = entity.target_temperature || entity.target_temperature_low; and using that reference instead. Probably same for most of the Number casts used multiple times.
This reverts commit b09657b.
v3 Climate component draft. Introduces:
It could do with a bit more design work, ideally just needs a little more horizontal space