Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix textinput & datetime value with . #91

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Prefix textinput & datetime value with . #91

merged 2 commits into from
Apr 29, 2024

Conversation

RebbePod
Copy link
Contributor

Similar to #44 & #48

The text box wasn't updating to match remote state after manually changing inside the webserver frontend

Copy link

netlify bot commented Apr 28, 2024

Deploy Preview for esphome-webserver ready!

Name Link
🔨 Latest commit 5c00895
🔍 Latest deploy log https://app.netlify.com/sites/esphome-webserver/deploys/662df013bab8ea00088e89d7
😎 Deploy Preview https://deploy-preview-91--esphome-webserver.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RebbePod
Copy link
Contributor Author

Tested it with the text component only. But it is working, so I assume it's the same fix for datetime

@RebbePod
Copy link
Contributor Author

Updated the v3 version files. But it didn't fix it in my test

@RFDarter
Copy link
Contributor

The text box wasn't updating to match remote state after manually changing inside the webserver frontend

What exacly do you mean by that?
If you type some Text in the textbox it is not displayed?
Or do you mean the Text you typed in is showing but not send to the esp?

Did you hit enter after changing the text?

Updated the v3 version files. But it didn't fix it in my test

I am not a JS guy at all, but how could
.value=.... instead of value=...
fix it?

Did you test if the js side sends the http request to the esp after changing a value?

If that works fine did the the esp response with the updated value?

@jesserockz
Copy link
Member

@RFDarter Its the other way around. When a value is changed, and the state is received from the ESP to the webserver frontend, the control box is not updated to reflect the new state.

@jesserockz jesserockz merged commit 7c1c976 into esphome:dev Apr 29, 2024
7 checks passed
@RFDarter
Copy link
Contributor

RFDarter commented Apr 29, 2024

@RFDarter Its the other way around. When a value is changed, and the state is received from the ESP to the webserver frontend, the control box is not updated to reflect the new state.

So you mean when it is changed from HA or inside the esp itself it is send correctly to the js side, but not updated?
And only the text component has that problem?

But how is this pr fixing it?

@RebbePod
Copy link
Contributor Author

RebbePod commented May 1, 2024

@RFDarter I don't fully understand how it's working, I just followed the example of the other PRs

@RFDarter
Copy link
Contributor

RFDarter commented May 1, 2024

@RebbePod which PRs?
Could you Post a link?
What would .value do ?

@RebbePod
Copy link
Contributor Author

RebbePod commented May 1, 2024

@RFDarter see first comment.

@RebbePod
Copy link
Contributor Author

RebbePod commented May 3, 2024

Any ideas how to fix this for v3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants