Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all unused data-plane gateway assets in the codebase #1299

Merged

Conversation

kiahna-tucker
Copy link
Member

Issues

The issues directly below are advanced by this PR:
#1297

Changes

1297

The following features are included in this PR:

  • Remove all unused data-plane gateway assets in the codebase (e.g., environment variables, types, utils, etc.).

Tests

Manually tested

Approaches to testing include, but are not limited to, the following:

  • Validate that the happy paths of all client workflows remain unchanged.

  • Validate that the integration of the new, control-plane endpoints remains unchanged.

Automated tests

N/A

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

N/A

@kiahna-tucker kiahna-tucker changed the title Kiahna tucker/dpg depreciation/remove legacy assets Remove all unused data-plane gateway assets in the codebase Oct 8, 2024
@kiahna-tucker kiahna-tucker added the change:planned This is a planned change label Oct 8, 2024
@kiahna-tucker kiahna-tucker marked this pull request as ready for review October 8, 2024 14:57
@kiahna-tucker kiahna-tucker requested a review from a team as a code owner October 8, 2024 14:57
Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - just a static review

@kiahna-tucker kiahna-tucker merged commit 54f64a0 into main Oct 9, 2024
3 checks passed
@kiahna-tucker kiahna-tucker deleted the kiahna-tucker/dpg-depreciation/remove-legacy-assets branch October 9, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:planned This is a planned change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants