-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use testify instead of t.Fatal in tests/common package (part 2) #18860
base: main
Are you sure you want to change the base?
Conversation
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @ahrtr |
41af5ee
to
82c6211
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmorel-35 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
82c6211
to
9274dc6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 26 files with indirect coverage changes @@ Coverage Diff @@
## main #18860 +/- ##
==========================================
- Coverage 68.80% 68.77% -0.03%
==========================================
Files 420 420
Lines 35532 35532
==========================================
- Hits 24448 24438 -10
- Misses 9662 9666 +4
- Partials 1422 1428 +6 Continue to review full report in Codecov by Sentry.
|
b8868c1
to
7e7b6bd
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
7e7b6bd
to
59a8434
Compare
/ok-to-test |
/test pull-etcd-integration-1-cpu-amd64 |
I hold on this to apply gofumpt first |
This uses testify instead of testing for t.Fatal calls