Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling global fetch and cache instrumentation #130

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

DaniFoldi
Copy link
Contributor

Fixes # [insert GH issue number(s)].

What this PR solves / how to test:

I was working on e2e tests for this package using the new vitest pool, and ran into a pile of errors when using fetch mocks and instrumented global fetch at the same time. To solve that (and possibly other issues), here's a config option to disable cache and fetch auto-instrumentation.

Copy link
Collaborator

@jahands jahands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jahands jahands merged commit f10e4cd into evanderkoogh:main Apr 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants