fix: Adding try-finally in instrumentClientFetch to ensure spans are … #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…closed on non HTTP errors such as Network connection lost.
|
Hey @sathiya-s1, thank you so much for this, this is exactly what is so awesome about open-source. You spotting a mistake, not just fixing it, but fixing it for everyone else who uses the API.. Apologies for the delay, it has been a few busy weeks. Would you be able to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…closed on non HTTP errors such as Network connection lost.
Fixes # [insert GH issue number(s)].
What this PR solves / how to test:
Errors in fetch that aren't handled by Cloudflare such as intermittent connection failures to other workers or durable objects currently result in the span remaining open. This small fix ensures that the spans are closed on any such unhandled errors.