Experimental Instrumentation of the cloudflare WebSocketPair API for workers #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrowny
reviewed
Mar 22, 2024
|
|
||
| export function setConfig(config: ResolvedTraceConfig, ctx = context.active()) { | ||
| // I could not get the context to work properly, so I'm using a global fallback. | ||
| // I suspect this is because I am not initialising the config properly in the WS instrumentation. | ||
| if (!fallbackConfig) { |
There was a problem hiding this comment.
this is actually a bug in this library and/or with context combined with websockets. I tried instrumenting WS on my own and I get the same thing as here: #14
There was a problem hiding this comment.
Hey I think it's an async local storage issue. Happy to jump on a call and work on this together if you would like
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @evanderkoogh,
This instruments websocket message and close handling.
This is a pretty hacky PR and I would appreciate your feedback on how to make it ready to merge :)
The major issue I ran into was making sure setConfig ran before getActiveConfig was called, I didn't manage this in the end so ended up adding a hack into config.ts to make the tracing work. I have probably done something obviously wrong
It adds spanEvents for accept, send, and close such that we can see how the websocket connection is behaving on the server, it currently makes no effort to add a parent span from the client message. From what I can see there would not be a good way to infer the traceparent reliably.