[WIP] Benchmarking geth+evmc with static libs #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Apr 12, 2019
| @@ -22,10 +22,10 @@ ExternalProject_Add(wabt | |||
| CMAKE_ARGS | |||
| -DCMAKE_INSTALL_PREFIX=<INSTALL_DIR> | |||
| -DCMAKE_BUILD_TYPE=Release | |||
| -DWITH_EXCEPTIONS=ON | |||
| -DWITH_EXCEPTIONS=OFF | |||
There was a problem hiding this comment.
Why does this needs to be turned off?
There was a problem hiding this comment.
It matches wabt default build options.
This breaks some EEI. Long term it would be worth to re-implement EEI without exceptions.
axic
reviewed
Apr 12, 2019
| @@ -569,11 +569,15 @@ void BinaryenEngine::verifyContract(wasm::Module & module) | |||
| "Contract export (\"memory\") missing." | |||
| ); | |||
|
|
|||
| /* | |||
| ***** in the metering benchmarks, inline-block and inline-super both export the inline useGas functions | |||
There was a problem hiding this comment.
It was a workaround to make the wast code use the debug name useGas for the function (if the inline function wasn't exported, its name would get mangled by the metering injector).
axic
reviewed
Apr 12, 2019
axic
changed the title
axic
force-pushed
the
benchmarking
branch
2 times, most recently
from
3730c1c
to
03f1c31
Compare
|
Is there something we can salvage from this PR? |
axic
force-pushed
the
benchmarking-static-lib
branch
from
4e187a0
to
3e01d99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge, for reference only,