-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++11 conversion #7
base: master
Are you sure you want to change the base?
Conversation
My Jenkins job is failing a standard Linux build (not OpenWrt) because I don't have |
Hmm? GCC has defaulted to C++11 since 4.8. configure.ac is a good place to add, yes. |
Well I got it to compile fine by adding the Jenkins is running on an Ubuntu 16.04 box: Running this magic command seems to indicate that c++ 1998 (or maybe 2003?) is the default:
|
Ah yes GCC changed their policy regarding that with GCC7. They default to highest stable version now. One reason for the C++11 changes is smaller compiled size. |
Found with modernize-use-auto. Signed-off-by: Rosen Penev <[email protected]>
Found with modernize-use-noexcept Signed-off-by: Rosen Penev <[email protected]>
Found with modernize-use-equals-default Signed-off-by: Rosen Penev <[email protected]>
Found with modernize-use-override Signed-off-by: Rosen Penev <[email protected]>
Found with hicpp-use-equals-delete Signed-off-by: Rosen Penev <[email protected]>
Found with readability-redundant-string-cstr Signed-off-by: Rosen Penev <[email protected]>
Found with modernize-use-auto Signed-off-by: Rosen Penev <[email protected]>
Found with modernize-convert-loop Signed-off-by: Rosen Penev <[email protected]>
Rebased. |
Merged your PR. |
Cleans up the code a bit with modern techniques. Some size improvements.
Still compatible with uClibc++. Only needs a modern C++ compiler (GCC 4.8.1).