Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Notifications: first draft #13

Merged
merged 14 commits into from
Jan 3, 2024
Merged

✨ Notifications: first draft #13

merged 14 commits into from
Jan 3, 2024

Conversation

jgalat
Copy link
Contributor

@jgalat jgalat commented Dec 15, 2023 •
edited
Loading

  • Introduces One Signal for notifications
  • Add in-app subscription (external id still needs to be setup)
  • Backend utilities for sending
  • Adds Pomelo notifications endpoint
  • Some draft icons to use in notifications
  • OneSignal SDK service worker for web notifications. DISCLAIMER: I still couldn't make web notifications work. For some reason when running bun web or exporting (bunx expo export --platform web) and serving, the html in +html.tsx is being ditched and a default template is being used. Been trying to fix that..
  • Metro: Ignore /contracts/lib/ path

closes #3

@vercel Vercel
Copy link

vercel bot commented Dec 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pomelo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 29, 2023 2:37pm

@cruzdanilo cruzdanilo marked this pull request as draft December 18, 2023 15:28
sebipap
sebipap reviewed Dec 26, 2023
View reviewed changes
app.config.ts Show resolved Hide resolved
@jgalat jgalat marked this pull request as ready for review December 27, 2023 18:43
sebipap
sebipap reviewed Dec 28, 2023
View reviewed changes
app.config.ts Show resolved Hide resolved
app.config.ts Show resolved Hide resolved
app.config.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
pomelo/api/transactions/v1/notifications.ts Outdated Show resolved Hide resolved
@cruzdanilo cruzdanilo merged commit 8822a0f into main Jan 3, 2024
3 checks passed
@cruzdanilo cruzdanilo deleted the notifications branch January 3, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebipap sebipap sebipap approved these changes

@cruzdanilo cruzdanilo cruzdanilo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement push notifications
3 participants
@jgalat @cruzdanilo @sebipap