Search three languages at once #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice idea ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version is buggy, but I can't figure out the bugs.
This fork lets you search three languages at once, similar to what happens in xbmc.
The problems are:
Searching languages that are the same that are the defaults (saved in the config .xml file) makes the program only search subtitles in the english language. This doesn't make any sense, but shouldn't be too hard to fix if you understand the code properly.
Second, I couldn't get the changing of the second and third language in the config menu to work. Something weird happened, where the last language changed would overwrite the others before it. I commented out the code relative to this part, so that the fork worked.
Given this, to change the dafault languages one needs to edit the config xml file, changing the lines:
pob
eng
I'd be very happy if this idea was implemented, and these small bugs corrected.
I think this would be very useful as I, for example, being portuguese, usually search in Portugal's portuguese, brazil's portuguese, and also english. Searching three times is very annoying.