Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 MAINTAIN: Resolve CI Failures #443

Closed
wants to merge 2 commits into from

Conversation

KyleKing
Copy link
Collaborator

@KyleKing KyleKing commented Sep 24, 2024

Update the RTD configuration to include the now required build.os setting: https://github.com/readthedocs/readthedocs.org/blob/2f48c81e9ce162bbd34229e897db84044b00fe31/docs/user/config-file/v2.rst#buildos

And to address the pre-commit/flake8 error, we need to add an ignore rule because renaming the file to resolve the warning would be breaking (e.g. https://github.com/executablebooks/mdformat-deflist/blob/919cc85cf8c750fd74550b65fa2a2a7728ca6628/mdformat_deflist/plugin.py#L5)

Merging this PR will unblock the open documentation PRs (#425, #418, #440, #427)

@KyleKing KyleKing self-assigned this Sep 24, 2024
@KyleKing KyleKing changed the title ci: update RTD configuration 🔧 MAINTAIN: update RTD configuration Sep 24, 2024
@KyleKing KyleKing changed the title 🔧 MAINTAIN: update RTD configuration 🔧 MAINTAIN: Resolve CI Failures Sep 24, 2024
@hukkin
Copy link
Member

hukkin commented Oct 3, 2024

Thanks!

I removed some clutter and merged here with you as co-author.

I wonder why readthedocs bothers with a version field in their conf file if they break it regardless 😄

@hukkin hukkin closed this Oct 3, 2024
@KyleKing KyleKing deleted the fix-ci-rtd branch October 3, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants