Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit summary length hints (warning at 50, error at 72) #1954

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Commit summary length hints (warning at 50, error at 72) #1954

wants to merge 1 commit into from

Conversation

OchirErkhembayar
Copy link

@OchirErkhembayar OchirErkhembayar commented Nov 16, 2023 •
edited
Loading

This Pull Request fixes/closes #1635.

It changes the following:

  • Added a warning_text to styles
  • Updated warning for commit message to display yellow text at 50 glyphs and red text at 72 glyphs instead of just red at 50

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@pBouillon
Copy link

Not a maintainer but I would very much like to be able to override those values from a config file or equivalent

@extrawurst
Copy link
Owner

yeah this needs to be in the config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commit summary length hints (warning at 50, error at 72)
3 participants
@OchirErkhembayar @pBouillon @extrawurst