This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
feat(handler): add methods to mutate and remove backtrace/spantrace #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibfahn
force-pushed
the
clear_backtrace
branch
from
b681cce
to
d3da7e1
Compare
gibfahn
commented
Apr 18, 2023
Comment on lines
+25
to
+33
| /// Return a mutable reference to the captured `Backtrace` type | ||
| pub fn backtrace_mut(&mut self) -> Option<&mut Backtrace> { | ||
| self.backtrace.as_mut() | ||
| } | ||
|
|
||
| /// Remove the captured `Backtrace` if present. | ||
| pub fn clear_backtrace(&mut self) { | ||
| self.backtrace = None; | ||
| } |
There was a problem hiding this comment.
I initially tried to use the .backtrace_mut() as in #130 (comment) , and it didn't work as it returns Option<&mut Backtrace> rather than &mut Option<Backtrace>.
I think that's more idiomatic rust, and so having two methods makes sense, but if you'd rather we delete clear_backtrace() and change the signature of backtrace_mut to:
pub fn backtrace_mut(&mut self) -> &mut Option<Backtrace> {that works for me too.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits (oldest to newest)
d3da7e1 feat(handler): add methods to mutate and remove backtrace/spantrace
Fixes: #130