Public OauthToken struct #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibraries to go through the oauth flow
| @@ -41,8 +41,8 @@ type ContactsParams struct { | |||
| Query string `json:"query,omitempty"` | |||
| } | |||
|
|
|||
| // The OAuth Tokens Struct returned from OAuth Authentication | |||
| type oauthTokens struct { | |||
| // OauthTokens the OAuth Tokens Struct returned from OAuth Authentication | |||
There was a problem hiding this comment.
Nit: In my opinion, this change does not add value to the comment. Since the OauthTokens struct is on the next line, adding its name to this comment does not seem to add information to this comment. I would remove this, but will approve anyways as it's not hurting anything and is subjective.
brandon-busby
approved these changes
May 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently using another library to go through the OAuth flow. I would like to use this library to call Coinbase but not to authenticate.